Ildar Absalyamov has posted comments on this change. Change subject: ASTERIXDB-1154: index-left-outer-join with LIMIT now works. ......................................................................
Patch Set 3: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/470/3/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java: Line 49: * Operator subtree that matches the following patterns, and provides convenient access to its nodes: pattern should be changed to "(select | order | limit)?" Moreover the same comment about matching pattern should be changed in IntroduceJoinAccessMethodRule Line 98: if (subTreeOp.getOperatorTag() == LogicalOperatorTag.SELECT) { All conditions above yield the same "skip" semantics, hence I would put all of them in one big if statement https://asterix-gerrit.ics.uci.edu/#/c/470/3/asterix-app/src/test/resources/runtimets/queries/index-leftouterjoin/probe-pidx-with-join-btree-sidx1-orderby-limit-01/probe-pidx-with-join-btree-sidx1-orderby-limit-01.2.update.aql File asterix-app/src/test/resources/runtimets/queries/index-leftouterjoin/probe-pidx-with-join-btree-sidx1-orderby-limit-01/probe-pidx-with-join-btree-sidx1-orderby-limit-01.2.update.aql: Line 28: load dataset TweetMessages excess whitespace -- To view, visit https://asterix-gerrit.ics.uci.edu/470 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93591e6cc5aa19751466136a7ecdee871ba67f83 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-HasComments: Yes
