Ian Maxon has posted comments on this change. Change subject: Add method to check state of buffer cache ......................................................................
Patch Set 5: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/497/5/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java File hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java: Line 497: if(c.valid){ > what's the purpose/meaning of this flag? It's to determine whether or not the content of the page is correct. When a file is closed it should mark this as false on all of the cached pages of that file, so they're not returned on accident. Line 520: return true; > Can the "c" in reachableDpids.add(c.dpid) be different from the "cPage" in It could be possible I think- say if there was one invalid page with the same dpid as a valid page. -- To view, visit https://asterix-gerrit.ics.uci.edu/497 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80fb891b5310252143854a336b591bf3f8cd4ba8 Gerrit-PatchSet: 5 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Young-Seok Kim <kiss...@gmail.com> Gerrit-HasComments: Yes
