Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1152: Delete storage data of old instances ......................................................................
Patch Set 8: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/469/8/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContext.java File asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContext.java: Line 131: private final boolean initialRun; Why does "initialRun" get stored in the context? It seems that the lifecycle of this information is not very well aligned with the lifecycle of the context. https://asterix-gerrit.ics.uci.edu/#/c/469/8/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java File asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepository.java: Line 96 This should probably be removed before committing this change. Line 70: * to make sure when ResourceIdFactory is initialize on this LocalResourceRepository, it gets the correct value. s/intialize/initialized/ Line 121: System.out.println("storageMetadataDir: " + storageMetadataDir.getAbsolutePath()); ditto Line 135: if (storageRootDirName.startsWith(System.getProperty("file.separator"))) { What's the difference between 'System.getProperty("file.separator")' and java.io.File.separator? Also, does this convention work on another OS (e.g. Windows)? https://asterix-gerrit.ics.uci.edu/#/c/469/8/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepositoryFactory.java File asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/PersistentLocalResourceRepositoryFactory.java: Line 34: this.systemState = systemState; It seems strange to materialize the state in this factory, as the state of the system probably changes over time, but this factory doesn't. -- To view, visit https://asterix-gerrit.ics.uci.edu/469 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb6c6949bdf2ed6c3e491fa66a23491ff34fc830 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-HasComments: Yes
