Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1159: make ARecordType read-only and separate its 
mutable state to RuntimeRecordTypeInfo.
......................................................................


Patch Set 4:

(1 comment)

>>Does this change also allow runtimets/queries/records/get-record-fields test 
>>to be enabled? The test had sporadic failures on jenkins. If so, it would be 
>>nice to include it in the patch.

@Preston, with this patch, runtimets/queries/records/get-record-fields is not 
sporadic --- it deterministically fails.  I think you can continue to 
investigate that test case once this patch is merged.

https://asterix-gerrit.ics.uci.edu/#/c/501/4/asterix-om/src/main/java/org/apache/asterix/om/types/runtime/RuntimeRecordTypeInfo.java
File 
asterix-om/src/main/java/org/apache/asterix/om/types/runtime/RuntimeRecordTypeInfo.java:

Line 71:             // if the time doesn't change, we just skip the reset.
> time = type
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/501
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbfa73907ae9422a4ad85dc4db5fa568855beb17
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <[email protected]>
Gerrit-Reviewer: Ildar Absalyamov <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Preston Carman <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-HasComments: Yes

Reply via email to