Ian Maxon has posted comments on this change. Change subject: Make LSM bulkload append-only and write-once. ......................................................................
Patch Set 42: (10 comments) Comments from review with Murtadha https://asterix-gerrit.ics.uci.edu/#/c/255/42/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java File hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java: Line 296: public void abort() throws HyracksDataException { Remove this if so an RTE is thrown if the bufferCache is null https://asterix-gerrit.ics.uci.edu/#/c/255/42/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java File hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java: Line 1127: Make this static. https://asterix-gerrit.ics.uci.edu/#/c/255/42/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java File hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java: Line 106: int freePage = -1; Change to INVALID_DPID Line 168: if( mdPage <0 ){ change to INVALID_DPID Line 388: return -1; return INVALID_DPID https://asterix-gerrit.ics.uci.edu/#/c/255/42/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java File hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java: Line 38: public static int TREE_METADATA_NUM_PAGES = 2; make final https://asterix-gerrit.ics.uci.edu/#/c/255/42/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java File hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java: Line 364: throw Unimplemented exception https://asterix-gerrit.ics.uci.edu/#/c/255/42/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTree.java File hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTree.java: Line 103: ws Line 635: forceFlushDirtyPages(bufferCache, fileId, startPage, maxPage); remove silly casts https://asterix-gerrit.ics.uci.edu/#/c/255/42/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java File hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java: Line 117: public static void setDpid(ICachedPage page, long dpid) { make this do the BufferedFileHandle.getDpid thing too -- To view, visit https://asterix-gerrit.ics.uci.edu/255 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80fb891b5310252143854a336b591bf3f8cd4ba7 Gerrit-PatchSet: 42 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Young-Seok Kim <kiss...@gmail.com> Gerrit-HasComments: Yes
