abdullah alamoudi has posted comments on this change. Change subject: Clean up compilation warnings. ......................................................................
Patch Set 1: Code-Review+1 (4 comments) LGTM. Very minot comments. Please, look at them and let me know what you think? https://asterix-gerrit.ics.uci.edu/#/c/505/1/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedFrameDiscarder.java File asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedFrameDiscarder.java: Line 43 why not remove the ctx from the parameters as well? https://asterix-gerrit.ics.uci.edu/#/c/505/1/asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedStorageStatistics.java File asterix-common/src/main/java/org/apache/asterix/common/feeds/FeedStorageStatistics.java: Line 22 Is there a duplicate for this class? or is it just unused? https://asterix-gerrit.ics.uci.edu/#/c/505/1/asterix-common/src/main/java/org/apache/asterix/common/feeds/FrameDistributor.java File asterix-common/src/main/java/org/apache/asterix/common/feeds/FrameDistributor.java: Line 75: public FrameDistributor(IHyracksTaskContext ctx, FeedId feedId, FeedRuntimeType feedRuntimeType, int partition, should we remove from constructor parameters as well? https://asterix-gerrit.ics.uci.edu/#/c/505/1/asterix-tools/src/main/java/org/apache/asterix/tools/external/data/SocketClientAdapter.java File asterix-tools/src/main/java/org/apache/asterix/tools/external/data/SocketClientAdapter.java: Line 50: this.port = port; remove ctx from constructor? -- To view, visit https://asterix-gerrit.ics.uci.edu/505 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbfcd9c67f91d373c5f7269125778a5681021227 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
