Till Westmann has posted comments on this change. Change subject: Add a test case for Hyracks error reporting. ......................................................................
Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/527/1/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/rewriting/ErrorReportingTest.java File hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/rewriting/ErrorReportingTest.java: Line 76: throw new IllegalStateException("Error reporting fails!"); Should we just use a JUnit assertion here? Line 137: private class ThreadCountingActivityNode extends AbstractActivityNode { It is not clear to me why this is called ThreadCountingActivityNode. Could you add a comment to explain this? (Maybe to the test methods itself, explaining what is tested) -- To view, visit https://asterix-gerrit.ics.uci.edu/527 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3ac4c7b0a07eacbc448ce5724085eb8d1e6bc4d Gerrit-PatchSet: 1 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
