Preston Carman has posted comments on this change. Change subject: Impelemented the memory-bounded HashGroupby and HashJoin for BigObject ......................................................................
Patch Set 4: (6 comments) Here are a few comments and I will start reviewing the latest patch. https://asterix-gerrit.ics.uci.edu/#/c/398/4/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/BufferInfo.java File hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/BufferInfo.java: Line 46: ByteBuffer buffer; Move the class variables to the top of the class and add variable scope. (private?) https://asterix-gerrit.ics.uci.edu/#/c/398/4/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/EnumFreeSlotPolicy.java File hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/EnumFreeSlotPolicy.java: Line 23: SMALLEST_FIT, Add a java doc definition of each of these policies. https://asterix-gerrit.ics.uci.edu/#/c/398/4/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/FrameFreeSlotBiggestFirst.java File hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/FrameFreeSlotBiggestFirst.java: Line 29: class SpaceEntryFactory implements IResetableComparableFactory { Should the class and variable scope be defined? https://asterix-gerrit.ics.uci.edu/#/c/398/4/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/FrameFreeSlotLastFit.java File hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/FrameFreeSlotLastFit.java: Line 69: frameSpaces = Arrays.copyOf(frameSpaces, size * 2); Does this grow the frameSpaces to a size large than specified by the constructor? Should this be allowed? Or maybe rename the constructor variable to initialFrameCount... https://asterix-gerrit.ics.uci.edu/#/c/398/4/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VariableFramePool.java File hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VariableFramePool.java: Line 92: return used.nextClearBit(0); unused is one word. Line 96: return used.previousClearBit(lastPos); unused is one word. -- To view, visit https://asterix-gerrit.ics.uci.edu/398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I248f3a374fdacad7d57e49cf18d8233745e55460 Gerrit-PatchSet: 4 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Ian2 Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Pouria Pirzadeh <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
