Yingyi Bu has posted comments on this change. Change subject: Changes required to support MessageBroker implementation ......................................................................
Patch Set 8: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/485/8/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/AbstractRemoteService.java File hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/AbstractRemoteService.java: Line 23: public abstract class AbstractRemoteService implements IControllerService { Why do you need this abstract class since it just contains a constructor? https://asterix-gerrit.ics.uci.edu/#/c/485/8/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/INodeController.java File hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/INodeController.java: Line 57: public IIPCHandle getIPCHandle(); It seems to me you don't need to expose IIPCHandle to the outside. It is only used by: state.getNodeController().getIPCHandle().send(-1, result, null); Instead you can add a method: public void sendApplicationMessageToNC(....) in this interface, just to be symmetric to IClusterController.sendApplicationMessageToCC(...). In this way, you can encapsulate IIPCHandle, such that the runtime code doesn't need to undertand what does "-1" and "null" mean in "send(-1, result, null);", and it will only use: state.getNodeController().sendApplicationMessageToNC(....) https://asterix-gerrit.ics.uci.edu/#/c/485/8/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/NodeControllerRemoteProxy.java File hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/NodeControllerRemoteProxy.java: Line 99: public IIPCHandle getIPCHandle() { Do not expose that. https://asterix-gerrit.ics.uci.edu/#/c/485/8/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/IResourceIdFactory.java File hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/file/IResourceIdFactory.java: Line 27: long createId() throws Exception; Exception --> HyracksDataException Since it is used by the index runtime, HyracksDataException is for exceptions in that space. -- To view, visit https://asterix-gerrit.ics.uci.edu/485 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9f49234eebe912c48e7f71980433a9b42595741 Gerrit-PatchSet: 8 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: Yingyi Bu <ying...@google.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
