Murtadha Hubail has posted comments on this change. Change subject: First stage of external data cleanup ......................................................................
Patch Set 8: (19 comments) https://asterix-gerrit.ics.uci.edu/#/c/566/8/asterix-external-data/src/main/java/org/apache/asterix/external/provider/ParserFactoryProvider.java File asterix-external-data/src/main/java/org/apache/asterix/external/provider/ParserFactoryProvider.java: Line 52: return new HiveDataParserFactory(); Add missing types and default to unsupported. https://asterix-gerrit.ics.uci.edu/#/c/566/8/asterix-external-data/src/main/java/org/apache/asterix/external/runtime/GenericSocketFeedAdapter.java File asterix-external-data/src/main/java/org/apache/asterix/external/runtime/GenericSocketFeedAdapter.java: Line 34: This class is expected to be removed. https://asterix-gerrit.ics.uci.edu/#/c/566/8/asterix-external-data/src/main/java/org/apache/asterix/external/runtime/GenericSocketFeedAdapterFactory.java File asterix-external-data/src/main/java/org/apache/asterix/external/runtime/GenericSocketFeedAdapterFactory.java: Line 44: public class GenericSocketFeedAdapterFactory implements IFeedAdapterFactory { This class is expected to be removed. https://asterix-gerrit.ics.uci.edu/#/c/566/8/asterix-external-data/src/main/java/org/apache/asterix/external/runtime/SocketClientAdapter.java File asterix-external-data/src/main/java/org/apache/asterix/external/runtime/SocketClientAdapter.java: Line 30: This class is expected to be removed. https://asterix-gerrit.ics.uci.edu/#/c/566/8/asterix-external-data/src/main/java/org/apache/asterix/external/runtime/SocketClientAdapterFactory.java File asterix-external-data/src/main/java/org/apache/asterix/external/runtime/SocketClientAdapterFactory.java: Line 31: public class SocketClientAdapterFactory implements IFeedAdapterFactory { This class is expected to be removed. https://asterix-gerrit.ics.uci.edu/#/c/566/8/asterix-external-data/src/main/java/org/apache/asterix/external/runtime/TwitterFirehoseFeedAdapterFactory.java File asterix-external-data/src/main/java/org/apache/asterix/external/runtime/TwitterFirehoseFeedAdapterFactory.java: Line 72: this.configureFormat(outputType); Remove this call and add TODO to set the correct parser. Line 75: private void configureFormat(ARecordType outputType2) { Remove this method. https://asterix-gerrit.ics.uci.edu/#/c/566/8/asterix-external-data/src/main/java/org/apache/asterix/external/util/DNSResolver.java File asterix-external-data/src/main/java/org/apache/asterix/external/util/DNSResolver.java: Line 37: public class DNSResolver implements INodeResolver { Update class name to reflect new functionality. Line 89: AsterixRuntimeUtil.getNodeControllerMap(ncMap); Add a TODO to change this call and replace by calling AsterixClusterProperties https://asterix-gerrit.ics.uci.edu/#/c/566/8/asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java File asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java: Line 52: } if policyType == null, throw exception https://asterix-gerrit.ics.uci.edu/#/c/566/8/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java File asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java: Line 51: public static void addCompatabilityParameters(String adapterClassname, ARecordType itemType, Add the rest of the aliases Line 54: || adapterClassname.contains("HDFSAdapter")) { Replace by final constant https://asterix-gerrit.ics.uci.edu/#/c/566/8/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java File asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataConstants.java: Line 130: public static final String ALIAS_TWITTR_FIREHOSE_ADAPTER = "twitter_firehose"; TWITTER https://asterix-gerrit.ics.uci.edu/#/c/566/8/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java File asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java: Line 45: // Get a delimiter from the given configuration WS Line 90: return aString.contains(ExternalDataConstants.EXTERNAL_LIBRARY_SEPARATOR); Add TODO to check for the format instead of contains only Line 118: // TODO Auto-generated method stub complete the implementation. https://asterix-gerrit.ics.uci.edu/#/c/566/8/asterix-maven-plugins/lexer-generator-maven-plugin/src/main/resources/Lexer.java File asterix-maven-plugins/lexer-generator-maven-plugin/src/main/resources/Lexer.java: Line 92: public void setInputStream(java.io.Reader stream, char[] buffer) throws IOException{ Remove. Line 109: public void removeInputStream(){ Remove. https://asterix-gerrit.ics.uci.edu/#/c/566/8/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedIntakeOperatorNodePushable.java File asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedIntakeOperatorNodePushable.java: Line 89: // if (adapterFactory.isRecordTrackingEnabled()) { Add TODO here. -- To view, visit https://asterix-gerrit.ics.uci.edu/566 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04a8c4e494d8d1363992b6fe0bdbe6b2b3b7b767 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
