Ildar Absalyamov has posted comments on this change. Change subject: Enabled Datasets to use Datatypes from foreign Dataverses ......................................................................
Patch Set 8: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/558/8/asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql File asterix-app/src/test/resources/metadata/queries/basic/meta17/meta17.3.query.aql: Line 23 Why is this file removed? https://asterix-gerrit.ics.uci.edu/#/c/558/8/asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql File asterix-app/src/test/resources/metadata/queries/basic/meta18/meta18.3.query.aql: Line 22 Why is this file removed? https://asterix-gerrit.ics.uci.edu/#/c/558/8/asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java File asterix-metadata/src/main/java/org/apache/asterix/metadata/valueextractors/DatatypeNameValueExtractor.java: Line 59: // Get datatype that uses this anonymous datatype (there is only one) Seems like this data extractor is not used by anyone, since the secondary metadata "indices" are removed, right? -- To view, visit https://asterix-gerrit.ics.uci.edu/558 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24dbc04dcb2a4126fc8361ebe3104877a0d1f2bb Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
