Till Westmann has posted comments on this change. Change subject: Add Support for Upsert Operation ......................................................................
Patch Set 5: Code-Review+1 (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/476/5/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/ReplicateOperator.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/ReplicateOperator.java: Line 79: */ Should be resolved or an issue, but not a comment in the source code. https://asterix-gerrit.ics.uci.edu/#/c/476/5/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java: Line 342: } Seems that we could pull this out into a nice little private method with a switch and a few returns without breaks :) https://asterix-gerrit.ics.uci.edu/#/c/476/5/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/FrameTupleAccessor.java File hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/FrameTupleAccessor.java: Line 166: * They are safe as they don't print records. Printing records using IserializerDeserializer can print incorrect results or throw exceptions. line break? -- To view, visit https://asterix-gerrit.ics.uci.edu/476 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2705f43b6e6d187ee29b9ba5a7946d422990022a Gerrit-PatchSet: 5 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Taewoo Kim <wangs...@gmail.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Young-Seok Kim <kiss...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
