Till Westmann has posted comments on this change. Change subject: Impelemented the memory-bounded HashGroupby and HashJoin for BigObject ......................................................................
Patch Set 8: (3 comments) Not a review, just a few observations. And I really like the addition of the unit tests :) https://asterix-gerrit.ics.uci.edu/#/c/398/8//COMMIT_MSG Commit Message: Line 7: Impelemented the memory-bounded HashGroupby and HashJoin for BigObject s/Impelemented/Implemented/ https://asterix-gerrit.ics.uci.edu/#/c/398/8/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VariableFramePool.java File hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VariableFramePool.java: Line 47: * @param memBudgetInBytes the given memory budgets to allocate the frames. If it less than 0, it will be treated as unlimited budgets Line break? https://asterix-gerrit.ics.uci.edu/#/c/398/8/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/misc/LimitOperatorDescriptor.java File hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/misc/LimitOperatorDescriptor.java: Line 73: FrameUtils.appendToWriter(writer, partialAppender,fta, i); I think that this file could stay unmodified. -- To view, visit https://asterix-gerrit.ics.uci.edu/398 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I248f3a374fdacad7d57e49cf18d8233745e55460 Gerrit-PatchSet: 8 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Pouria Pirzadeh <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
