Taewoo Kim has posted comments on this change. Change subject: Initial fuzzy join framework with multiple split and temporary ngram fix. ......................................................................
Patch Set 5: (9 comments) Good! Generally, let's put more comments to make it more clear. https://asterix-gerrit.ics.uci.edu/#/c/530/5/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/PlanCompiler.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/PlanCompiler.java: Line 77: for (int i = n - 1; i >= 0; i--) { Why is this descending order? https://asterix-gerrit.ics.uci.edu/#/c/530/5/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractCommonOperatorsRule.java File algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractCommonOperatorsRule.java: Line 56: public class ExtractCommonOperatorsRule implements IAlgebraicRewriteRule { Can we put comments here? What does this rule do? And What operator patterns does this rule expect? Before - After? Line 64: private final HashMap<Mutable<ILogicalOperator>, Pair<Boolean, BitSet>> selectedMOMap = new HashMap<Mutable<ILogicalOperator>, Pair<Boolean, BitSet>>(); What is this map? Line 354: private ILogicalOperator extractPKProduction(ILogicalOperator root, LogicalVariable pk) throws AlgebricksException { Can we put the comments here? What does this function do? Line 371: private void mergeHomogeneousPK(ILogicalOperator op, List<LogicalVariable> pks) throws AlgebricksException { Can we put the comments here? What does this function do? Homogeneous PK? Line 411: private boolean isBinaryHomogeneous(IOptimizationContext context, ILogicalOperator candidate, ILogicalOperator peer) Can we put the comments here? What does this function do? And put more comments inside of the function? Line 570: private void computeClusters(Mutable<ILogicalOperator> parentRef, Mutable<ILogicalOperator> opRef, Plase put more comments inside of the function so that we can understand this more easily. https://asterix-gerrit.ics.uci.edu/#/c/530/5/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/misc/MaterializerTaskState.java File hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/misc/MaterializerTaskState.java: Line 70: RunFileReader in = out.createReader(); What's the difference between the old code and this one? https://asterix-gerrit.ics.uci.edu/#/c/530/5/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/misc/SplitOperatorDescriptor.java File hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/misc/SplitOperatorDescriptor.java: Line 126: activeMaterializedCount[partition] = numberOfActiveMaterializeReaders; How is this used? -- To view, visit https://asterix-gerrit.ics.uci.edu/530 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2487078d1821d7ad85bb745bfa31024bcdbea1f1 Gerrit-PatchSet: 5 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Inci Cetindil <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
