Taewoo Kim has posted comments on this change. Change subject: Fuzzyjoin rules enforcement/adjustment on RuleCollections and the testCases ......................................................................
Patch Set 8: (4 comments) Good! Please put more comments. Thank you. https://asterix-gerrit.ics.uci.edu/#/c/531/8/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/FuzzyUtils.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/FuzzyUtils.java: Line 122: Let's remove this red space. https://asterix-gerrit.ics.uci.edu/#/c/531/8/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ExtractFunctionsFromJoinConditionRule.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ExtractFunctionsFromJoinConditionRule.java: Line 63: */ I wonder why this refactoring is required? Line 87: private boolean assignFunctionExpressions(AbstractLogicalOperator joinOp, ILogicalExpression expr, Can we put more comments here? https://asterix-gerrit.ics.uci.edu/#/c/531/8/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java: Line 282: String groupByLeft = ""; Can we put more comments here? -- To view, visit https://asterix-gerrit.ics.uci.edu/531 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia829133808deeaba3c847ac383aa8ae76fa5d87e Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Inci Cetindil <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
