abdullah alamoudi has posted comments on this change. Change subject: Add Support for Upsert Operation ......................................................................
Patch Set 7: (9 comments) https://asterix-gerrit.ics.uci.edu/#/c/476/7/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/SinkOperator.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/SinkOperator.java: Line 87 > Revert the file? Done https://asterix-gerrit.ics.uci.edu/#/c/476/7/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/VariableUtilities.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/VariableUtilities.java: Line 45: * A list to be filled with variables used in the logical operator op. > WS Done https://asterix-gerrit.ics.uci.edu/#/c/476/7/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ISearchPredicate.java File hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/ISearchPredicate.java: Line 37: * @throws HyracksDataException > WS Done Line 39: public ITupleReference getLowKey(); > I tried to find the reason, why this method is on this interface now, when Actually, at first, I called it getSearchKey() since I needed the search key to pass to the searchOpCallback with the before() call. Young-Seok requested that I change its name to getLowKey since I return the lowKey. In fact, it only makes a difference with point searches where the lowKey == highKey. Should I rename it again? https://asterix-gerrit.ics.uci.edu/#/c/476/7/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/NoOpOperationCallback.java File hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/NoOpOperationCallback.java: Line 45: // Do nothing. > WS Done Line 50: // Do nothing. > WS Done https://asterix-gerrit.ics.uci.edu/#/c/476/7/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTreeOpContext.java File hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTreeOpContext.java: Line 144 > Since we don't modify this file, can we revert it to its original state? Done https://asterix-gerrit.ics.uci.edu/#/c/476/7/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/common/TestOperationCallback.java File hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/common/TestOperationCallback.java: Line 51: // Do nothing. > WS Done Line 56: // Do nothing. > WS Done -- To view, visit https://asterix-gerrit.ics.uci.edu/476 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2705f43b6e6d187ee29b9ba5a7946d422990022a Gerrit-PatchSet: 7 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Taewoo Kim <wangs...@gmail.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Young-Seok Kim <kiss...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
