Yingyi Bu has posted comments on this change. Change subject: Fix test cases to work with the BigObject Groupby & Join ......................................................................
Patch Set 7: (1 comment) Can you add some runtime test queries (e.g., in runtimetes/queries/big-object/) to cover the "big object" code path in the hyracks change: https://asterix-gerrit.ics.uci.edu/#/c/398/ ? https://asterix-gerrit.ics.uci.edu/#/c/451/7/asterix-om/src/main/java/org/apache/asterix/om/base/ARecord.java File asterix-om/src/main/java/org/apache/asterix/om/base/ARecord.java: Line 92: sb.append("SCHEMALESS_INSTANCE"); I guess a schema less instance could look like this: ARecord: {} Thus, it's consistent with the case that fields is an array of size 0. -- To view, visit https://asterix-gerrit.ics.uci.edu/451 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aadec904af64cc2b7b03e6dff399a2288c21a7b Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
