Heri Ramampiaro has posted comments on this change. Change subject: ASTERIXDB-1255: Fix for potential issues related to object creation in Jaccard Similarity evaluation ......................................................................
Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/586/2/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java: Line 243: return; > So in this case, you set the hashTableSize according to the first encounter Yes, you are absolutely right, I still thought that it was run for every list, but of course that won't be the case... Now, a question that would still apply (which was the reason for why I proposed the dynamic table size in the first place) is what happen if the list size is larger than the original default value (which is in this case 100)? -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri Ramampiaro <[email protected]> Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Heri Ramampiaro <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
