abdullah alamoudi has posted comments on this change.

Change subject: Add flush() to IFrameWriter
......................................................................


Patch Set 11:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/585/11/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java
File 
asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java:

Line 195:                         } catch (InterruptedException e) {
> We shouldn't ignore this.
Again, this one was copied from a bug fix implemented by Young-Seok in his 
development branch and I didn't think much of it.

:-) Fixed now.


https://asterix-gerrit.ics.uci.edu/#/c/585/11/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java
File 
asterix-external-data/src/main/java/org/apache/asterix/external/provider/DatasourceFactoryProvider.java:

Line 31: import 
org.apache.asterix.external.input.record.reader.twitter.TwitterRecordReaderFactory;
> This is a nice repackaging - now we can see from the imports what inputs ar
:-)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/585
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id862ce9e9b1360864c6976f2aea2137092f51203
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to