Yingyi Bu has posted comments on this change. Change subject: Fix ASTERIXDB-1255 ......................................................................
Patch Set 4: -Code-Review Heri, actually, I think the change will be problematic because the hash table size is set only according to the first encountered tuple's list. It is not as safe as before because if the first list is of size 1, then the hash table size will be 1 forever. Therefore, I think we can just keep the size as 100 unless you figure out how to dynamically change the size of BinaryHashTable. -- To view, visit https://asterix-gerrit.ics.uci.edu/586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08c550d35d864df08792369d38ff81012e3976af Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri Ramampiaro <[email protected]> Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Heri Ramampiaro <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: No
