Till Westmann has posted comments on this change. Change subject: Move to non-copy-based evaluator interfaces for scalar functions, aggregate functions, running aggregate functions and unnest functions. ......................................................................
Patch Set 3: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/614/3/algebricks/algebricks-examples/piglet-example/src/main/java/org/apache/hyracks/algebricks/examples/piglet/runtime/functions/IntegerEqFunctionEvaluatorFactory.java File algebricks/algebricks-examples/piglet-example/src/main/java/org/apache/hyracks/algebricks/examples/piglet/runtime/functions/IntegerEqFunctionEvaluatorFactory.java: Line 55: int v1 = IntegerPointable.getInteger(out1.getByteArray(), 0); Why is 0 the right offset here? https://asterix-gerrit.ics.uci.edu/#/c/614/3/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/IAggregateEvaluatorFactory.java File algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/IAggregateEvaluatorFactory.java: Line 27: public IAggregateEvaluator createAggregateEvaluator(IHyracksTaskContext context) throws AlgebricksException; ctx was good to me :) https://asterix-gerrit.ics.uci.edu/#/c/614/3/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/ICopySerializableAggregateFunctionFactory.java File algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/ICopySerializableAggregateFunctionFactory.java: Line 26: public interface ICopySerializableAggregateFunctionFactory extends Serializable { I don't understand this name. Is this a good time to find a better one? (interfaces are modified anyway ...). https://asterix-gerrit.ics.uci.edu/#/c/614/3/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/IScalarEvaluatorFactory.java File algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/IScalarEvaluatorFactory.java: Line 27: public IScalarEvaluator createScalarEvaluator(IHyracksTaskContext context) throws AlgebricksException; ctx was good for me :) https://asterix-gerrit.ics.uci.edu/#/c/614/3/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/IUnnestingEvaluatorFactory.java File algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/IUnnestingEvaluatorFactory.java: Line 27: public IUnnestingEvaluator createUnnestingEvaluator(IHyracksTaskContext context) throws AlgebricksException; ctx? https://asterix-gerrit.ics.uci.edu/#/c/614/3/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/encoding/VarLenIntEncoderDecoder.java File hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/encoding/VarLenIntEncoderDecoder.java: Line 81: } Should we throw something, for the else case? It seems that we have corrupt data if we have nothing in the first on-continued byte. Is that right? -- To view, visit https://asterix-gerrit.ics.uci.edu/614 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92a630550f3d45a7a5f00cfbc93e7b049b06330d Gerrit-PatchSet: 3 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Jianfeng Jia <jianfeng....@gmail.com> Gerrit-Reviewer: Michael Blow <michael.b...@couchbase.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
