Preston Carman has posted comments on this change. Change subject: Move to non-copy-based evaluator interfaces for all function implementations, including: - scalar functions, - aggregate functions, - running aggregate functions, - unnesting functions ......................................................................
Patch Set 11: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/615/11/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordAddFieldsDescriptor.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordAddFieldsDescriptor.java: Line 104: final IPointable abvs0 = new VoidPointable(); Update the variable name to represent the new type. Line 105: final IPointable abvs1 = new VoidPointable(); Update the variable name to represent the new type. https://asterix-gerrit.ics.uci.edu/#/c/615/11/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordMergeDescriptor.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordMergeDescriptor.java: Line 103: final IPointable abvs0 = new VoidPointable(); Update the variable name to represent the new type. Line 104: final IPointable abvs1 = new VoidPointable(); Update the variable name to represent the new type. -- To view, visit https://asterix-gerrit.ics.uci.edu/615 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If132857cf8d707ce96951f12ba6dd86f54aa4069 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Jianfeng Jia <jianfeng....@gmail.com> Gerrit-Reviewer: Michael Blow <michael.b...@couchbase.com> Gerrit-Reviewer: Preston Carman <prest...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
