Taewoo Kim has posted comments on this change. Change subject: Intersect the 2ndary indexes before primary search ......................................................................
Patch Set 2: (6 comments) Can we add runtime test cases, too? https://asterix-gerrit.ics.uci.edu/#/c/578/2/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceUnionRule.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceUnionRule.java: Line 112: //? why only the first one? Let's remove this comment. https://asterix-gerrit.ics.uci.edu/#/c/578/2/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java: Line 132: protected Pair<IAccessMethod, Index> chooseBestIndex(Map<IAccessMethod, AccessMethodAnalysisContext> analyzedAMs) { the method name can be chooseBestIndexes() since it returns all possible indexes. https://asterix-gerrit.ics.uci.edu/#/c/578/2/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IAccessMethod.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IAccessMethod.java: Line 41: public interface IAccessMethod extends Comparable<IAccessMethod>{ Purpose of this Comparable? Line 88: public ILogicalOperator createSecondaryToPrimaryPlan(Mutable<ILogicalExpression> conditionRef, Reason to move this method into here? https://asterix-gerrit.ics.uci.edu/#/c/578/2/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java: Line 145: // one primary + 2nd indexes, choose primary index directly. Let's put more detailed comments here. Line 170: private ILogicalOperator connectAllSubRootsWithIntersect(List<ILogicalOperator> subRoots, Let's put more detailed comments here. -- To view, visit https://asterix-gerrit.ics.uci.edu/578 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie167918fb23e39c8728840e4a90c1b85bf1bde85 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
