Taewoo Kim has posted comments on this change. Change subject: Upto threeway fuzzy join based on prefix pruning ......................................................................
Patch Set 10: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/530/10/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractCommonOperatorsRule.java File algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/ExtractCommonOperatorsRule.java: Line 371: private ILogicalOperator extractPKProduction(ILogicalOperator root, LogicalVariable pk) throws AlgebricksException { I think more correct name is extractOpThatProducesGivenPK(). And let's rename the variable name from pk to primaryKeyVar to make it clear. Line 388: private void mergeHomogeneousPK(ILogicalOperator op, List<LogicalVariable> pks) throws AlgebricksException { pks -> primaryKeyVars? Line 392: if (mOp == null || !mOp.getOperatorTag().equals(LogicalOperatorTag.DATASOURCESCAN)) Only Datasourcescan can generate PK? What about unnestmap? https://asterix-gerrit.ics.uci.edu/#/c/530/10/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushGroupByIntoSortRule.java File algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushGroupByIntoSortRule.java: Line 57: hasInMem = true; Sets hasInMem, and then? https://asterix-gerrit.ics.uci.edu/#/c/530/10/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushNestedOrderByUnderPreSortedGroupByRule.java File algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/PushNestedOrderByUnderPreSortedGroupByRule.java: Line 61: hasInMem = true; Where is this hasInMem used? https://asterix-gerrit.ics.uci.edu/#/c/530/10/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java File algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java: Line 101: hasInMem = true; Where is this hasInMem used? -- To view, visit https://asterix-gerrit.ics.uci.edu/530 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2487078d1821d7ad85bb745bfa31024bcdbea1f1 Gerrit-PatchSet: 10 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Inci Cetindil <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
