Yingyi Bu has posted comments on this change. Change subject: Intersect the 2ndary indexes before primary search ......................................................................
Patch Set 5: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/577/5/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/IntersectPOperator.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/IntersectPOperator.java: Line 87: .getPartitioningProperty(); Here, the logic should be slightly different from HashJoin. Because for the hash join case, all the variables from its input branches are propagated through the operator. For the intersection case, all the input variables are no longer live after the intersect operator. For example, the "pp" here could ORDERED_PARTITION $1, but $1 is not in iop.getOutputVars(). What needs to be done here is to describe the data property in terms of variables in iop.getOutputVars(). Since you have mapping from input vars to output vars, it is easy to do this, just that you might need to consider different partition property types, because some of them have variables while some of them doesn't have variables. Or alternatively, you could add a substituteVariables method to the IPartitionProperty. -- To view, visit https://asterix-gerrit.ics.uci.edu/577 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic16c67c529ca19d8b1a5439ddef22760945fd0d7 Gerrit-PatchSet: 5 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
