Taewoo Kim has posted comments on this change. Change subject: Fuzzyjoin rules with debug information as well as the testCases ......................................................................
Patch Set 20: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/531/20/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java: Line 239: fuzzy.add(new InlineSubplanInputForNestedTupleSourceRule()); The purpose of adding this rule here? Can we put some comments why there are required? https://asterix-gerrit.ics.uci.edu/#/c/531/20/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ExtractFunctionsFromJoinConditionRule.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ExtractFunctionsFromJoinConditionRule.java: Line 63: */ Can we put more comments on this rule? Why is this rule required? https://asterix-gerrit.ics.uci.edu/#/c/531/20/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java: Line 144: throws AlgebricksException { Can we remove this file from the patch set since there are no changes. -- To view, visit https://asterix-gerrit.ics.uci.edu/531 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia829133808deeaba3c847ac383aa8ae76fa5d87e Gerrit-PatchSet: 20 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Inci Cetindil <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
