Till Westmann has posted comments on this change. Change subject: Fix ASTERIXDB-1292 ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/636/2/asterix-om/src/main/java/org/apache/asterix/om/base/temporal/DateTimeFormatUtils.java File asterix-om/src/main/java/org/apache/asterix/om/base/temporal/DateTimeFormatUtils.java: Line 878: int valFieldCount = (int) Math.ceil(Math.log10(val + 0.1)); Couldn't we just use the length of String.valueOf(val) here? Line 907: int msFieldCount = (int) Math.ceil(Math.log10(ms + 0.1)); Same here? -- To view, visit https://asterix-gerrit.ics.uci.edu/636 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee8e9b87145d9b3511874cd11d61ae87acdc94c7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
