Ian Maxon has posted comments on this change. Change subject: Enabled Feed Tests and Added External Library tests ......................................................................
Patch Set 12: Code-Review+1 (4 comments) Cool stuff. I didn't look at the ClassAd parser itself though; that sort of stuff is Greek to me :) . We should definitely check in asterix-externaldata/src/test/resources/testdata.txt as binary though. Just a few thoughts other than that. https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java File asterix-app/src/test/java/org/apache/asterix/test/common/TestLibrarian.java: Line 37: import net.lingala.zip4j.core.ZipFile; Make sure you add this to NOTICE. It's ASL2 but not from the ASF. Line 93: public static void removeLibraryDir() throws IOException { Can there be a sanity check here about what's returned from getLibraryInstallDir()? It would really suck if someone set it to / ;) https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-app/src/test/resources/runtimets/testsuite.xml File asterix-app/src/test/resources/runtimets/testsuite.xml: Line 62: </test-case> It seems like a lot of these are still broken, maybe we can file an issue about it so we don't lose track? https://asterix-gerrit.ics.uci.edu/#/c/625/12/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/EmptyLineSeparatedRecordReader.java: Line 24: So maybe this is a stupid question, but why doesn't this situation count as a type of delimited text file? -- To view, visit https://asterix-gerrit.ics.uci.edu/625 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
