abdullah alamoudi has posted comments on this change. Change subject: Enabled Feed Tests and Added External Library tests ......................................................................
Patch Set 13: (50 comments) https://asterix-gerrit.ics.uci.edu/#/c/625/13/.gitattributes File .gitattributes: Line 19: # Exeplicitly declare binary files > Explicitly (sp.) Done https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java: Line 75: th.printStackTrace(); > printStackTrace() still here, I assume you meant to replace this with the L Done https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java File asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java: Line 90: if (feedLogManager.exists()) { > if(!feedLogManager.exists(){ Done https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java File asterix-external-data/src/test/java/org/apache/asterix/external/classad/AMutableCharArrayString.java: Line 37: value = new char[64]; > replace 64 by increment Done Line 235: public int fistNonDigitChar() { was intentional :p Done. https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java File asterix-external-data/src/test/java/org/apache/asterix/external/classad/AttributeReference.java: Line 97: boolean success = true; > success value is never changed. In case of failure, an exception will be th Done https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java File asterix-external-data/src/test/java/org/apache/asterix/external/classad/BuiltinClassAdFunctions.java: Line 50: return true; > what does it mean to return true here? I am not sure but this is matches the c++ implementation of the classad functions. https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java File asterix-external-data/src/test/java/org/apache/asterix/external/classad/InputStreamLexerSource.java: Line 109: return null; > return buffer? Done https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java File asterix-external-data/src/test/java/org/apache/asterix/external/classad/Operation.java: Line 41: /// List of supported operators > WS Done Line 110: * > WS Done Line 133: * > WS Done Line 147: * > WS Done Line 163: * > WS Done Line 674: // if op is binary, but not associative or commutative, disallow splitting > WS Done Line 826: // same operators on both children . since op!=NO_OP, neither are op1, > WS Done Line 927: // comparison between strings and non-exceptional non-string > WS Done Line 1218: // trap sigfpe and set the ClassAdExprFPE flag to true; on NT check the > WS Done https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java File asterix-external-data/src/test/java/org/apache/asterix/external/classad/test/FunctionalTester.java: Line 135: * > WS Done Line 145: // Then we parse to see what the user wants. > WS Done Line 219: * > WS Done Line 236: * > WS Done Line 261: * > WS Done Line 274: // We don't increment it until we use it. > WS Done Line 327: * > WS Done Line 371: // We have to be careful with substr() because with gcc 2.96, it likes to > WS Done Line 457: * > WS Done Line 520: * > WS Done Line 544: * > WS Done Line 573: * > WS Done Line 587: * > WS Done Line 630: * > WS Done Line 649: * > WS Done Line 675: * > WS Done Line 756: * > WS Done Line 764: > WS Done Line 791: > WS Done Line 795: * > WS Done Line 803: > WS Done Line 811: > WS Done Line 827: > WS Done Line 984: * > WS Done Line 1007: * > WS Done Line 1056: * > WS Done Line 1083: * > WS Done Line 1100: // We have to be careful with substr() because with gcc 2.96, it likes to > WS Done https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java File asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java: Line 139: * > WS Done Line 658: * > WS Done Line 727: * > WS Done Line 794: * > WS Done https://asterix-gerrit.ics.uci.edu/#/c/625/13/asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql File asterix-installer/src/test/resources/integrationts/library/queries/library-parsers/record-parser/record-parser.2.update.aql: Line 18: */ > This file is not needed Done -- To view, visit https://asterix-gerrit.ics.uci.edu/625 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a Gerrit-PatchSet: 13 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
