Till Westmann has posted comments on this change. Change subject: Enabled Feed Tests and Added External Library tests ......................................................................
Patch Set 16: (4 comments) Please add the TODOs to JIRA. There's only one more question on the FeedTupleForwarder. https://asterix-gerrit.ics.uci.edu/#/c/625/16/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java File asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java: Line 62: // TODO: Find a better way to do flushes, this doesn't fit here Could you add a JIRA issue pointing to this interface? Line 69: // TODO: Find a better way to perform logging. this doesn't fit here Could you add a JIRA issue pointing to this interface? https://asterix-gerrit.ics.uci.edu/#/c/625/16/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java: Line 66: this.maxRecordSize = ctx.getInitialFrameSize() * 2; Shouldn't this be divided by 2? https://asterix-gerrit.ics.uci.edu/#/c/625/16/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java File asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java: Line 66: // TODO: Instead, use a factory just like data source and data parser. Please add a JIRA issue. -- To view, visit https://asterix-gerrit.ics.uci.edu/625 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
