Ildar Absalyamov has posted comments on this change. Change subject: Support Change Feeds ......................................................................
Patch Set 2: (4 comments) The general comment that I have is lack of tests\examples which can show how to use chnageable feeds. Is that a restriction of our test framework? https://asterix-gerrit.ics.uci.edu/#/c/621/2/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedDataFlowController.java File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/ChangeFeedDataFlowController.java: Line 40: public void configure(Map<String, String> configuration, IHyracksTaskContext ctx) { This might initialize numOfFields properly and call super.configure() https://asterix-gerrit.ics.uci.edu/#/c/621/2/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java: Line 51: parse(record); So does FeedRecordDataFlowController gets ever used by itself? In this case it is not parsing anything, cause the parse method is empty! https://asterix-gerrit.ics.uci.edu/#/c/621/2/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java File asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java: Line 304: public void getFieldTypes(List<List<String>> fields, List<IAType> emptyList) throws AlgebricksException { Can that method return a list of nested fields types instead? https://asterix-gerrit.ics.uci.edu/#/c/621/2/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMSecondaryUpsertOperatorNodePushable.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMSecondaryUpsertOperatorNodePushable.java: Line 91: public static boolean isNull(PermutingFrameTupleReference t1) { Can't you reuse AsterixLSMPrimaryUpsertOperatorNodePushable.isNull() with field parameter equal to 0? -- To view, visit https://asterix-gerrit.ics.uci.edu/621 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If136a03d424970132dfb09f0dda56e160d4c0078 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
