Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1302 Fix Deadlock with Feed Connection ......................................................................
Patch Set 2: (8 comments) Just a few comments. https://asterix-gerrit.ics.uci.edu/#/c/660/2/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java File asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java: Line 90: System.err.println("Using the path: " + tempPath); Remove again? https://asterix-gerrit.ics.uci.edu/#/c/660/2/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java File asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java: Line 619: // #. initialize DatasetIdFactory if it is not initialized. I'm a little confused about all these changes to comments. Are they done by the formatter? If I run the formatter locally this doesn't happen .. https://asterix-gerrit.ics.uci.edu/#/c/660/2/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java File asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java: Line 62: // HDFSCluster.getInstance().setup(); We don't need that anymore? https://asterix-gerrit.ics.uci.edu/#/c/660/2/asterix-app/src/test/resources/runtimets/queries/feeds/drop-dataverse-with-disconnected-feed/drop-dataverse-with-disconnected-feed.4.update.aql File asterix-app/src/test/resources/runtimets/queries/feeds/drop-dataverse-with-disconnected-feed/drop-dataverse-with-disconnected-feed.4.update.aql: Line 20: * Description : Drop a dataverse with disconnected feed WS https://asterix-gerrit.ics.uci.edu/#/c/660/2/asterix-app/src/test/resources/runtimets/queries/feeds/drop-dataverse-with-disconnected-feed/drop-dataverse-with-disconnected-feed.5.ddl.aql File asterix-app/src/test/resources/runtimets/queries/feeds/drop-dataverse-with-disconnected-feed/drop-dataverse-with-disconnected-feed.5.ddl.aql: Line 20: * Description : Drop a dataverse with disconnected feed WS https://asterix-gerrit.ics.uci.edu/#/c/660/2/asterix-common/src/test/java/org/apache/asterix/test/server/OpenSocketFileTestServer.java File asterix-common/src/test/java/org/apache/asterix/test/server/OpenSocketFileTestServer.java: Line 80: } catch (Throwable th) { Ok, this is only test code. But maybe we should at least log what's happening here? https://asterix-gerrit.ics.uci.edu/#/c/660/2/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketInputStream.java: Line 36: private boolean closed; What is the meaning of this? Could you find a more expressive name? Line 77: if (closed) { Why is this the only "read" method that cares about "closed"? -- To view, visit https://asterix-gerrit.ics.uci.edu/660 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f6e982440d3577343f2479c3779653a9c3db614 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
