Ian Maxon has posted comments on this change. Change subject: ASTERIXDB-1287: Fixed Admin Console pages. ......................................................................
Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/557/3/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java File hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java: Line 288: o.put("rrd-ptr", rrdPtr); > ArrayUtils.subarray and Arrays.copyOfRange basically does the same thing. A Ok, I guess I am just confused now. Because the last comment said there was some difference. If we want to resize this array copying is the only way around it I guess. Looking at this more closely in context, I think I don't even understand why you would want to copy that range to begin with though. Aren't all of these arrays circular buffers, where rrdPtr is the head? -- To view, visit https://asterix-gerrit.ics.uci.edu/557 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3944ed0c972f227aa1397d1cf6608f78f5f8c540 Gerrit-PatchSet: 3 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Pritom Ahmed <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Pritom Ahmed <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-HasComments: Yes
