Taewoo Kim has posted comments on this change. Change subject: Added LeftOuterUnnestMap operator. ......................................................................
Patch Set 4: (4 comments) Thanks Yingyi. Regarding union type, could you be more specific? https://asterix-gerrit.ics.uci.edu/#/c/638/4/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/LeftOuterUnnestMapOperator.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/LeftOuterUnnestMapOperator.java: Line 39: public class LeftOuterUnnestMapOperator extends AbstractUnnestOperator { > can you add an AbstractUnnestMapOperator and then both UnnestMapOperator an OK. Let me try. Line 88: env.setVarType(variables.get(i), variableTypes.get(i)); > need to be union types here since it's left-outer-join semantics. I roughly understand this. Still, I don't fully understand how I can do this. Could you be more specific? https://asterix-gerrit.ics.uci.edu/#/c/638/4/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/SubstituteVariableVisitor.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/SubstituteVariableVisitor.java: Line 345: } > share the code with visistUnnestMapOperator? Good idea. Let me try. https://asterix-gerrit.ics.uci.edu/#/c/638/4/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/UsedVariableVisitor.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/UsedVariableVisitor.java: Line 327: for (Mutable<ILogicalExpression> e : op.getAdditionalFilteringExpressions()) { > Share the code with visitUnnestMapOperator() by adding a common private met Good idea. Let me try. -- To view, visit https://asterix-gerrit.ics.uci.edu/638 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4525899cf8e5e43551aa2ac2a78806ef6cc85e58 Gerrit-PatchSet: 4 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
