Till Westmann has posted comments on this change. Change subject: Support Change Feeds and Ingestion of Records with MetaData) ......................................................................
Patch Set 5: (12 comments) some more https://asterix-gerrit.ics.uci.edu/#/c/620/5/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IMetadataProvider.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IMetadataProvider.java: Line 73: List<Mutable<ILogicalExpression>> additionalNonFilteringKeys) throws AlgebricksException; Could we move this list of variables next to the other lists of variables in the argument list? Line 75: public default Pair<IOperatorDescriptor, AlgebricksPartitionConstraint> getInsertRuntime( method is not used Line 212: List<Mutable<ILogicalExpression>> additionalNonFilteringKeys) throws AlgebricksException; Could we move this list of variables next to the other lists of variables in the argument list? Line 214: public default Pair<IOperatorDescriptor, AlgebricksPartitionConstraint> getUpsertRuntime( method is not used https://asterix-gerrit.ics.uci.edu/#/c/620/5/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/ProjectOperator.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/ProjectOperator.java: Line 60: this(v, new ArrayList<Mutable<ILogicalExpression>>()); Why do we add an empty list here but not in the other constructor? Line 119: public List<Mutable<ILogicalExpression>> getExpressions() { Could we remove this method and just pass the correct set of expressions to the constructor? https://asterix-gerrit.ics.uci.edu/#/c/620/5/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java: Line 410: pprintExprList(op.getPrevSecondaryKeyExprs(), buffer, indent); Is this the same line twice? https://asterix-gerrit.ics.uci.edu/#/c/620/5/algebricks/algebricks-examples/piglet-example/src/main/java/org/apache/hyracks/algebricks/examples/piglet/metadata/PigletMetadataProvider.java File algebricks/algebricks-examples/piglet-example/src/main/java/org/apache/hyracks/algebricks/examples/piglet/metadata/PigletMetadataProvider.java: Line 245: public Pair<IOperatorDescriptor, AlgebricksPartitionConstraint> getInsertRuntime( Could we put these back into the order they were in before? https://asterix-gerrit.ics.uci.edu/#/c/620/5/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/ArrayTupleBuilder.java File hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/ArrayTupleBuilder.java: Line 37: @Deprecated please add "use IFrameFieldAppender.appendField to append fields directly" to the deprecation annotation https://asterix-gerrit.ics.uci.edu/#/c/620/5/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/test/file/CursorTest.java File hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/test/file/CursorTest.java: Line 19: package org.apache.hyracks.dataflow.std.test.file; Can we keep this in package "org.apache.hyracks.dataflow.std.file"? Line 77: if (cursor.isDoubleQuoteIncludedInThisField) { Why is this done in the test? Shouldn't the cursor do that? Line 84: System.err.println("Test case failed. Expected nuumber of fields in each record is " + numOfFields s/nuumber/number/ -- To view, visit https://asterix-gerrit.ics.uci.edu/620 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3749349e2b9f1b03c8b310eb99d3f44d08be77df Gerrit-PatchSet: 5 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
