Yingyi Bu has posted comments on this change. Change subject: Support Change Feeds and Ingestion of Records with MetaData ......................................................................
Patch Set 9: (12 comments) https://asterix-gerrit.ics.uci.edu/#/c/621/9/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FunctionToVariableRule.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FunctionToVariableRule.java: Line 50: // The rule can only apply once. Why the name of the rule needs to be changed? IMO, it is not a general FunctionToVariableRule, but only works for "Meta". https://asterix-gerrit.ics.uci.edu/#/c/621/9/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetClosedRecordConstructorsRule.java: Line 122: for (int i = 0; i < (n / 2); i++) { remove auto-parenthesis? https://asterix-gerrit.ics.uci.edu/#/c/621/9/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-meta-pk-in-meta/feed-with-meta-pk-in-meta.1.ddl.aql File asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-meta-pk-in-meta/feed-with-meta-pk-in-meta.1.ddl.aql: Line 45: ("reader"="localfs"), tab -> spaces https://asterix-gerrit.ics.uci.edu/#/c/621/9/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-meta-pk-in-meta/feed-with-meta-pk-in-meta.3.sleep.aql File asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-meta-pk-in-meta/feed-with-meta-pk-in-meta.3.sleep.aql: Line 24: 4000 what does this query test? Or is it just a place holder for me to fill in real queries? https://asterix-gerrit.ics.uci.edu/#/c/621/9/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_02/feeds_02.1.ddl.aql File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_02/feeds_02.1.ddl.aql: Line 36: timestamp : string WS https://asterix-gerrit.ics.uci.edu/#/c/621/9/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.1.ddl.aql File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_10/feeds_10.1.ddl.aql: Line 39: } WS https://asterix-gerrit.ics.uci.edu/#/c/621/9/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_11/feeds_11.1.ddl.aql File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_11/feeds_11.1.ddl.aql: Line 36: } WS https://asterix-gerrit.ics.uci.edu/#/c/621/9/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.1.ddl.aql File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_12/feeds_12.1.ddl.aql: Line 39: } WS https://asterix-gerrit.ics.uci.edu/#/c/621/9/asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.1.ddl.aql File asterix-app/src/test/resources/runtimets/queries/feeds/issue_230_feeds/issue_230_feeds.1.ddl.aql: Line 36: } WS https://asterix-gerrit.ics.uci.edu/#/c/621/9/asterix-app/src/test/resources/runtimets/queries/hints/issue_251_dataset_hint_7/issue_251_dataset_hint_7.1.ddl.aql File asterix-app/src/test/resources/runtimets/queries/hints/issue_251_dataset_hint_7/issue_251_dataset_hint_7.1.ddl.aql: Line 36: } WS https://asterix-gerrit.ics.uci.edu/#/c/621/9/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java File asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java: Line 804: keyType = recType.getSubFieldType(pidxKeyFieldNames.get(j)); IAType keyType = recType.getSubFieldType(pidxKeyFieldNames.get(j)); https://asterix-gerrit.ics.uci.edu/#/c/621/9/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java File asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java: Line 306: public void getFieldTypes(List<List<String>> fields, List<IAType> emptyList) throws AlgebricksException { void getFieldTypes(List<List<String>> fields, List<IAType> emptyList) -> List<IAType> getFieldTypes(List<List<String>> fields() So that the client code doesn't need to always construct an empty list before calling it. -- To view, visit https://asterix-gerrit.ics.uci.edu/621 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If136a03d424970132dfb09f0dda56e160d4c0078 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
