Michael Blow has posted comments on this change. Change subject: Coverity Fixes ......................................................................
Patch Set 2: (1 comment) response to Till's comments on SimilarityJaccardEvaluator.java https://asterix-gerrit.ics.uci.edu/#/c/715/2/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/SimilarityJaccardEvaluator.java: Line 202: protected int probeHashMap(AbstractAsterixListIterator probeIter, int buildListSize, int probeListSize) > This looks like a scary change. Did this evaluator work before? Or did we a This method implementation doesn't use these parameters at all, so the change itself is a no-op. However...: In the subclass where this is overridden (SimilarityJaccardCheckEvaluator), the parameters are in the changed order. Also, the only caller of this method (in this class, ~line 171), the parameters in the order expected by the subclass i.e. changed order. >> int intersectionSize = probeHashMap(probeList, buildListSize, >> probeListSize); ...so I think this is a correct fix to avoid confusion in the future. -- To view, visit https://asterix-gerrit.ics.uci.edu/715 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8927126f505481e83dd5b9e6e5ccd75bb67d8188 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
