Steven Jacobs has posted comments on this change. Change subject: Equivalence induced operations and the testCases The following commits from your working branch will be included: exchange optimization for lookup and delete when the search condition is merely composed of the single primary key. ......................................................................
Patch Set 16: Code-Review+1 I think it would be good if Yingyi had some time to look at this. A couple of comments: 1) Still needs runtime/optimizer tests 2) Have you checked how it reacts to inserts with multiple records (as we discussed Friday)? Hopefully it should not apply in those cases, but this isn't completely clear to me from the code. That's why I'm hoping to get another set of eyes. -- To view, visit https://asterix-gerrit.ics.uci.edu/428 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaad567eecc4c91019ecba56cca085acde34d5196 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wenhai Li <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: No
