abdullah alamoudi has posted comments on this change.

Change subject: Fixed Bugs Caused by Disabling Installer Tests
......................................................................


Patch Set 2:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/736/2/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTreeWithBuddy.java
File 
hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTreeWithBuddy.java:

Line 616:         if (createComponent) {
> You shouldnt have to create/activate. What breaks when removing these new a
maybe you don't need to create but definitely need to activate, otherwise, they 
don't open the file and you end up getting an exception when the buffer cache 
doesn't know what file you're looking for.
Just look at any other lsm index and you will find that.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/736
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic77f4ee76a77f4b49cac6835bbb976eb9dc92d3a
Gerrit-PatchSet: 2
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to