Murtadha Hubail has posted comments on this change.

Change subject: Improve Error Handling in Local Directory Feeds
......................................................................


Patch Set 13:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/720/13/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedFrameCache.java
File 
asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedFrameCache.java:

Line 169:             frameWriter.nextFrame(frame);
revert


https://asterix-gerrit.ics.uci.edu/#/c/720/13/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
File 
asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java:

Line 94: 
add TODO to restructure HDFS specific stuff.


https://asterix-gerrit.ics.uci.edu/#/c/720/13/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFSInputStream.java
File 
asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/LocalFSInputStream.java:

Line 154:             if (th.getCause().getMessage().contains("Malformed input 
stream")) {
change this to exception type


https://asterix-gerrit.ics.uci.edu/#/c/720/13/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
File 
asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java:

Line 56:     private LinkedList<Path> dirs;
final


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/720
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08d89229e33c91532b1038ba9f7a372f7ca1fdb5
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to