Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1360 Fix Error Message for Unknown Format ......................................................................
Patch Set 3: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/767/3/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-indexing/rc-format/rc-format.1.ddl.sqlpp File asterix-app/src/test/resources/runtimets/queries_sqlpp/external-indexing/rc-format/rc-format.1.ddl.sqlpp: Line 46: ("hive-serde"="org.apache.hadoop.hive.serde2.columnar.ColumnarSerDe")); What is "parser", "input-format", and "format" when parameterizing feeds? https://asterix-gerrit.ics.uci.edu/#/c/767/3/asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java File asterix-external-data/src/main/java/org/apache/asterix/external/input/HDFSDataSourceFactory.java: Line 195: } This is a little confusing. We get 3 different readers based on what parameters? Maybe a comment could help? https://asterix-gerrit.ics.uci.edu/#/c/767/3/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java File asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java: Line 87: } Can we remove this try-catch? -- To view, visit https://asterix-gerrit.ics.uci.edu/767 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4aac833e30bd7c5a7706f5c8116383c2362c964 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
