Murtadha Hubail has posted comments on this change. Change subject: ASTERIXDB-1356: report file not found ......................................................................
Patch Set 3: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/771/3/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java File asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java: Line 92: } catch (HyracksDataException e) { This catch is not needed. https://asterix-gerrit.ics.uci.edu/#/c/771/3/asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java File asterix-external-data/src/main/java/org/apache/asterix/external/util/LocalFileSystemUtils.java: Line 67: }); > I am not sure about this. think of the case where the user gives the path a I think there should be a distinction between the case where passing a directory with no files is accepted (feed), and when it is not. Using localfs is a very common use case. It is worth getting its error messages as specific as possible. -- To view, visit https://asterix-gerrit.ics.uci.edu/771 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
