abdullah alamoudi has posted comments on this change. Change subject: Control Number of Readers for LocalFS Data ......................................................................
Patch Set 3: (12 comments) https://asterix-gerrit.ics.uci.edu/#/c/776/3/asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java File asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java: Line 69: * > WS Done https://asterix-gerrit.ics.uci.edu/#/c/776/3/asterix-app/src/test/resources/runtimets/testsuite.xml File asterix-app/src/test/resources/runtimets/testsuite.xml: Line 53: <test-group name="feeds"> > Revert this file Done https://asterix-gerrit.ics.uci.edu/#/c/776/3/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java File asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java: Line 30: * > WS Done Line 51: * > WS Done Line 67: * > WS Done https://asterix-gerrit.ics.uci.edu/#/c/776/3/asterix-external-data/src/main/java/org/apache/asterix/external/api/IStreamNotificationHandler.java File asterix-external-data/src/main/java/org/apache/asterix/external/api/IStreamNotificationHandler.java: Line 24: public void notifyNewSource() throws IOException; > change exception to HyracksDataException and add java docs. Done https://asterix-gerrit.ics.uci.edu/#/c/776/3/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/CSVToRecordWithMetadataAndPKConverter.java File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/CSVToRecordWithMetadataAndPKConverter.java: Line 50: try { > remove try/catch. is there a reason to keep it? Done https://asterix-gerrit.ics.uci.edu/#/c/776/3/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java: Line 123: public void notifyNewSource() throws IOException { > throw unsupported? Done https://asterix-gerrit.ics.uci.edu/#/c/776/3/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamFactory.java File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamFactory.java: Line 130: // After this change, each node partition which has at least one file > Remove "After this change" and make comment clearer Done Line 131: Map<String, String[]> stores = AsterixAppContextInfo.getInstance().getMetadataProperties().getStores(); > use getMetadataProperties().getNodePartitions to make it clearer Done https://asterix-gerrit.ics.uci.edu/#/c/776/3/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java File asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java: Line 77: try { > do you need some kind of protection here in case multiple partitions call i init() must only be called only in one of two cases: 1. the beginning of the job. 2. In case of the watcher dropping some events. Fixed now. Done. https://asterix-gerrit.ics.uci.edu/#/c/776/3/asterix-external-data/src/main/java/org/apache/asterix/external/util/NodeResolver.java File asterix-external-data/src/main/java/org/apache/asterix/external/util/NodeResolver.java: Line 62: return value; > Revert Done -- To view, visit https://asterix-gerrit.ics.uci.edu/776 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9d5ece656220d5f562cc385f882c5ddfd3283a6 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
