abdullah alamoudi has posted comments on this change. Change subject: ASTERIXDB-1356: report file not found ......................................................................
Patch Set 8: With the current implementation, a few things can go wrong IMO: 1. if a user specified a directory path and the path was found to be empty, we throw an exception. I don't think that is the correct behavior. What I would expect: If the directory is found, then regardless of whether it contains files or not, this should not throw an exception. 2. if a user specified a set of paths in a single NC, The first path was found to have at least one file, even if we don't find the other paths at all, no exception is thrown. What I would expect: If any of the passed paths doesn't exist, we throw an exception. -- To view, visit https://asterix-gerrit.ics.uci.edu/771 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
