Chris Hillery has posted comments on this change.

Change subject: Allow for optional modules in build.
......................................................................


Patch Set 3:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/768/3/asterix-server/pom.xml
File asterix-server/pom.xml:

Line 53:           <useWildcardClassPath>true</useWildcardClassPath>
This is not strictly necessary, but it makes the resulting asterixnc/asterixcc 
scripts neater.


Line 137:           <exists>../asterix-opt/pom.xml</exists>
Profile activation is not inherited from parent modules, or perhaps a profile 
defined in a child overrides the parent profile. In any case, I couldn't find a 
neater way than this to cause the optional behaviour to activate both here and 
in the top-level pom.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/768
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib99bfb3f92dfaa66dc2299db31b734adb5cceeca
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery <[email protected]>
Gerrit-Reviewer: Chris Hillery <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to