Till Westmann has posted comments on this change. Change subject: Overhaul of Hyracks configuration management. ......................................................................
Patch Set 4: (14 comments) Just comments on comments so far .. https://asterix-gerrit.ics.uci.edu/#/c/336/4/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/IApplicationConfig.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/IApplicationConfig.java: Line 14: */ This it the wrong license header. Line 21: * Created by ceej on 6/26/15. Ideally there's no author attribution in ASF source files (yes, we do have exceptions to that rule in the codebase). https://asterix-gerrit.ics.uci.edu/#/c/336/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/TriggerNCWork.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/TriggerNCWork.java: Line 14: */ Wrong license Line 29: * Created by ceej on 6/18/15. Please no author attribution. https://asterix-gerrit.ics.uci.edu/#/c/336/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/application/IniApplicationConfig.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/application/IniApplicationConfig.java: Line 14: */ Wrong license Line 23: * Created by ceej on 6/26/15. Please no author attribution. https://asterix-gerrit.ics.uci.edu/#/c/336/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/IniUtils.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/IniUtils.java: Line 14: */ Wrong license. Line 24: * Created by ceej on 7/23/15. Please no author attribution. https://asterix-gerrit.ics.uci.edu/#/c/336/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java: Line 154: WS Line 166: WS https://asterix-gerrit.ics.uci.edu/#/c/336/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java: Line 14: */ Wrong license Line 36: * Created by ceej on 5/28/15. Please no author attribution. https://asterix-gerrit.ics.uci.edu/#/c/336/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCServiceConfig.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCServiceConfig.java: Line 14: */ Wrong license Line 20: * Created by ceej on 5/28/15. Please no author attribution. -- To view, visit https://asterix-gerrit.ics.uci.edu/336 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3027c8c839f25ea858790bd3340187f4b11f212 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Chris Hillery <c...@lambda.nu> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
