Till Westmann has posted comments on this change. Change subject: Refactored the AbstractComparisonEvaluator. ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/801/2//COMMIT_MSG Commit Message: Line 9: The refactoring allows the comparison code to be used from other lodations, s/lodations/locations/ https://asterix-gerrit.ics.uci.edu/#/c/801/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/AIntervalPointable.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/AIntervalPointable.java: Line 114: throw new AsterixException("Unsupported interval type."); Could you also add a string representation of the type tag to the error message? -- To view, visit https://asterix-gerrit.ics.uci.edu/801 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42e0e8cf71207bb862334cd0629e8c024ff0556c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Preston Carman <prest...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Preston Carman <prest...@apache.org> Gerrit-Reviewer: Taewoo Kim <wangs...@yahoo.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
