Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1409: fix the type check for functions with two string arguments. ......................................................................
Patch Set 2: Code-Review+2 (3 comments) Looks good to me. Feel free to forward the +2 if you decide to address the comments. https://asterix-gerrit.ics.uci.edu/#/c/829/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/AbstractBinaryStringTypeComputer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/AbstractBinaryStringTypeComputer.java: Line 52: throw new AlgebricksException(e); Does wrapping this exception do anything useful? Line 85: throw new AlgebricksException("First argument should be String Type."); Would be nice to include the offending type in the error message. Line 89: throw new AlgebricksException("Second argument should be String Type."); Would be nice to include the offending type in the error message. -- To view, visit https://asterix-gerrit.ics.uci.edu/829 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd36d9f5ee0f7d6d20afdff2e0669d6be6c6769b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <michael.b...@couchbase.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
