Ian Maxon has posted comments on this change. Change subject: MBR size optimization for point data in R-Tree ......................................................................
Patch Set 1: Code-Review+2 (1 comment) LGTM really, nothing besides some nit picking. With all the tests why's the pointMBR flag set to false though? https://asterix-gerrit.ics.uci.edu/#/c/831/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java: Line 285: AlgebricksMetaOperatorDescriptor asterixAssignOp = createAssignOp(spec, sourceOp, I feel like making these just separate variables would be clearer. The use of so many inline ternary operators is kind of hard to follow for me. -- To view, visit https://asterix-gerrit.ics.uci.edu/831 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic48304a221f462c66bb1417f291b0ce4f2ce7581 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Young-Seok Kim <kiss...@gmail.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-HasComments: Yes
