Yingyi Bu has posted comments on this change. Change subject: Deadlock-free locking protocol is enabled ......................................................................
Patch Set 3: (12 comments) Most changes look good to me. One thing is that the code style format seems different from the standard one: http://asterixdb.apache.org/dev-setup.html Taewoo had a similar problem and fixed that after reinstalling latest Eclipse. I have also inlined some minor comments. https://asterix-gerrit.ics.uci.edu/#/c/825/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/UpsertCommitRuntime.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/UpsertCommitRuntime.java: Line 52: } Did you use the asterixdb codestyle? The code didn't change, but the formatting gets changed. I tried to reformat that file in my Eclipse but didn't see changes. https://asterix-gerrit.ics.uci.edu/#/c/825/3/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILockManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ILockManager.java: Line 45: * @param JobThreadId remove this annotation Line 60: * @param JobThreadId remove this annotation Line 67: * @param JobThreadId remove this annotation Line 80: * @param JobThreadId remove this annotation Line 91: * @param JobThreadId remove this annotation Line 102: * @param JobThreadId remove this annotation https://asterix-gerrit.ics.uci.edu/#/c/825/3/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataNode.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataNode.java: Line 151: public List<Dataset> getDataverseDatasets(JobId jobId, String dataverseName) code format https://asterix-gerrit.ics.uci.edu/#/c/825/3/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMPrimaryUpsertOperatorNodePushable.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMPrimaryUpsertOperatorNodePushable.java: Line 112: appender = new FrameTupleAppender(writeBuffer); does this conflict with line 129? https://asterix-gerrit.ics.uci.edu/#/c/825/3/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/AbstractIndexModificationOperationCallback.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/AbstractIndexModificationOperationCallback.java: Line 65: logRecord.setLogType(LogType.UPDATE); Why not do that in the constructor as before? It looks that the parameter is a constant. https://asterix-gerrit.ics.uci.edu/#/c/825/3/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java: Line 51: public static final long NILL = -1l; -1l->-1L https://asterix-gerrit.ics.uci.edu/#/c/825/3/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionSubsystem.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionSubsystem.java: Line 141: private int reportIntervalInSeconds; Can you add a sub-bullet in the commit message to describe the addition of this profiling capability and what's the use of it? -- To view, visit https://asterix-gerrit.ics.uci.edu/825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie58ae2f519baa53599e99b51bd61ea5f8366dafd Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Young-Seok Kim <kiss...@gmail.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: Young-Seok Kim <kiss...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
